From Mike.Sullivan at sun.com  Thu Aug 20 22:57:06 2009
From: Mike.Sullivan at sun.com (Mike.Sullivan at sun.com)
Date: Thu, 20 Aug 2009 12:57:06 -0700 (PDT)
Subject: minor Makefile.in issue
Message-ID: <200908201957.n7KJv642587943@yavin.Eng.Sun.COM>


I'm pulling 6.17.00 into Solaris and Sun make is a bit unhappy about the generated
Makefile:

$ /usr/ccs/bin/make
mksh: Fatal error in reader: Unmatched `(' on line
Current working directory /builds/sfw-pkgs/usr/src/cmd/tcsh/tcsh-6.17.00

as it doesn't like me enough to give me the line number, I diffed the Makefile.in's
and do see a problem:

466c466
< $(srcdir)/tests/testsuite: $(srcdir)/tests/package.m4 $(srcdir}/tests/testsuite.at $(TESTFILES)
---
> $(srcdir)/tests/testsuite: tests/package.m4 tests/testsuite.at $(TESTFILES)

that third srcdir reference is mixing brace types, I think it should pick one and
stick with it :) 

	Mike


From christos at zoulas.com  Thu Aug 20 23:59:48 2009
From: christos at zoulas.com (Christos Zoulas)
Date: Thu, 20 Aug 2009 16:59:48 -0400
Subject: minor Makefile.in issue
In-Reply-To: <200908201957.n7KJv642587943@yavin.Eng.Sun.COM>
	from Mike.Sullivan@sun.com (Aug 20, 12:57pm)
Message-ID: <20090820205948.6C0D05654E@rebar.astron.com>

On Aug 20, 12:57pm, Mike.Sullivan at sun.com (Mike.Sullivan at sun.com) wrote:
-- Subject: minor Makefile.in issue

| 
| I'm pulling 6.17.00 into Solaris and Sun make is a bit unhappy about the generated
| Makefile:
| 
| $ /usr/ccs/bin/make
| mksh: Fatal error in reader: Unmatched `(' on line
| Current working directory /builds/sfw-pkgs/usr/src/cmd/tcsh/tcsh-6.17.00
| 
| as it doesn't like me enough to give me the line number, I diffed the Makefile.in's
| and do see a problem:
| 
| 466c466
| < $(srcdir)/tests/testsuite: $(srcdir)/tests/package.m4 $(srcdir}/tests/testsuite.at $(TESTFILES)
| ---
| > $(srcdir)/tests/testsuite: tests/package.m4 tests/testsuite.at $(TESTFILES)
| 
| that third srcdir reference is mixing brace types, I think it should pick one and
| stick with it :) 

Sounds good to me :-)

Thanks!

christos