file-4.16 is now available

[Radek Vokál]

On Mon, 2005-10-31 at 07:44 +0100, Radek Vokál wrote:
> file-4.16 stopped reporting a source on core files
> 
> $ file ./core.12863
> ./core.12863: ELF 32-bit LSB core file Intel 80386, version 1 (SYSV),
> SVR4-style
> 
> (missing from `')
> 

The problem seems to be in readelf.c with the FLAGS_DID_CORE patch, I
guess it shouldn't return unless the flag is set, eg. the last return
statement is useless. Quick patching fixes it... 

--- file-4.16/src/readelf.c.old	2005-10-17 20:41:44.000000000 +0200
+++ file-4.16/src/readelf.c	2005-10-31 08:34:35.000000000 +0100
@@ -546,11 +546,11 @@ donote(struct magic_set *ms, unsigned ch
 				return size;
 			*flags |= FLAGS_DID_CORE;
-		} else
-			return size;
+		} /* else
+			return size;*/
 	}
 
 	switch (os_style) {



Radek

> 
> 
> On Mon, 2005-10-17 at 13:30 -0400, Christos Zoulas wrote:
> > from ftp://ftp.astron.com/pub/file/file-4.16.tar.gz
> > 
> > Changes:
> > 
> > 1. don't close stdin in the library.
> > 2. search for elf notes in shared libraries too.
> > 3. open files with O_BINARY on cygwin
> > 
> > And as always magic fixes and additions.
> > 
> > christos
> > 
> > _______________________________________________
> > File mailing list
> > File at mx.gw.com
> > http://mx.gw.com/mailman/listinfo/file
> _______________________________________________
> File mailing list
> File at mx.gw.com
> http://mx.gw.com/mailman/listinfo/file
-- 
Radek Vokál <rvokal at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://mx.gw.com/pipermail/file/attachments/20051031/55eb5576/attachment.bin